Skip to content

Conversation

KartikSharma0
Copy link

Resolves #2687
Added a check that returns PathToolFsmState::Ready if the path tool is used on a raster layer.

@Keavon Keavon force-pushed the fix-raster-path-tool-bug branch from 581ff33 to e8a0e36 Compare September 16, 2025 04:32
@Keavon
Copy link
Member

Keavon commented Sep 16, 2025

!build

Copy link

📦 Build Complete for e8a0e36
https://96d679d7.graphite.pages.dev

@KartikSharma0
Copy link
Author

Video of the fix:

Graphite.path.tool.bugfix.mov

@KartikSharma0
Copy link
Author

Please let me know if the video above captures the expected behavior.

@Keavon
Copy link
Member

Keavon commented Sep 16, 2025

This does not remove anchors from the corners of the image. All it does is break the Path tool's ability to select stuff, either a box selection or even clicking on other valid points if multiple layers (including actual vector layers) are selected. Please give it another shot so it addresses the requested change (first sentence of this reply).

@Keavon Keavon marked this pull request as draft September 16, 2025 05:07
@KartikSharma0
Copy link
Author

So there shouldn't be any anchors displayed on the image at all when the path tool is selected? The path tool still works on the spline as shown, it's just ignoring the raster image.

@KartikSharma0
Copy link
Author

I added a check before showing the anchors/handles. Please let me know if this PR is in-line with what you expected now.

@KartikSharma0
Copy link
Author

Okay, I simplified the code changes. I think this PR should fulfill the requirements now.

@KartikSharma0 KartikSharma0 marked this pull request as ready for review September 19, 2025 00:40
Copy link

📦 Build Complete for fca9dab
https://f3db9350.graphite.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the path edit tool on one of the corners of a raster image breaks the graph
3 participants