Make new document with doubleclicking on empty tab space #3228
Conversation
|
Is the issue you have linked correct? |
i have fixed it now ,sorry |
|
|
||
| <LayoutCol on:pointerdown={() => panelType && editor.handle.setActivePanel(panelType)} class={`panel ${className}`.trim()} {classes} style={styleName} {styles}> | ||
| <LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }}> | ||
| <LayoutRow class="tab-bar" classes={{ "min-widths": tabMinWidths }} on:dblclick={() => editor.handle.newDocumentDialog()}> |
There was a problem hiding this comment.
If you add the click handler to a new element that fills the portion of the bar not occupied by tabs, you won’t need to stop event propagation. I think it feels a little cleaner.
There was a problem hiding this comment.
can you explain a little more?
There was a problem hiding this comment.
I think its about making 2 new LayoutCol. Left one should have contain existing document tab and the right one could have on:dblclick=()
There was a problem hiding this comment.
can you explain a little more?
I mean add a extra child to the tab bar at the end that takes all remaining space.
That child would have the dblclick listener.
Take a look at how I did it in a similar case
|
@timon-schelling can you please take a look at it? |
There was a problem hiding this comment.
Remove theses debug changes
|
I will never merge frontend changes without your approval. Just getting them into a state I think you would approve, so you need to spend less time. |
This is issue number #3215
Make new document with double clicking on empty tab space
Allowing user to create a new file by double clicking on the empty tab space
Recording.2025-09-26.202723.1.mp4
Closes #3215