Open
Conversation
Colors == Eye massage, I have OCD with colors in `.md` files, and had to fix it <3 Really cool changes you made. I have made almost all the same changes in my own version of `clean architecture`. I have no idea why the https://github.com/jasontaylordev/CleanArchitecture is as popular as it is.... These in particular really bugged me: * Scope Leaks (Layer leaks) galore * event calling madness * Wrongly placed classes. I really like the changes you made. I am also a fan of `Controller Endpoints` to keep the controllers skinny. Often people add a ton of methods into controllers, while the methods might be 'skinny', there are often many different methods within a controller and it can become chaotic. This helps force it to a single 'feature' workflow: [Ardalis.ApiEndpoints]https://github.com/ardalis/ApiEndpoints). I like most of Ardalis code to be honest, I have a few problems with his version of [Clean Architecture](https://github.com/ardalis/CleanArchitecture), but its much better than the one that you originally forked. Again, thanks for the awesome code, its always nice to read and use good code to enhance your own habits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colors == Eye massage, I have OCD with colors in
.mdfiles, and had to fix it <3Really cool changes you made. I have made almost all the same changes in my own version of
clean architecture. I have no idea why the https://github.com/jasontaylordev/CleanArchitecture is as popular as it is.... These in particular really bugged me:I really like the changes you made.
I am also a fan of
Controller Endpointsto keep the controllers skinny. Often people add a ton of methods into controllers, while the methods might be 'skinny', there are often many different methods within a controller and it can become chaotic. This helps force it to a single 'feature' workflow: [Ardalis.ApiEndpoints]https://github.com/ardalis/ApiEndpoints). I like most of Ardalis code to be honest, I have a few problems with his version of Clean Architecture, but its much better than the one that you originally forked.Again, thanks for the awesome code, its always nice to read and use good code to enhance your own habits