Skip to content

Expose credential_count in IOC feeds and enable filtering by credential usage . Closes #1294#1295

Open
drona-gyawali wants to merge 1 commit intoGreedyBear-Project:developfrom
drona-gyawali:api/cred
Open

Expose credential_count in IOC feeds and enable filtering by credential usage . Closes #1294#1295
drona-gyawali wants to merge 1 commit intoGreedyBear-Project:developfrom
drona-gyawali:api/cred

Conversation

@drona-gyawali
Copy link
Copy Markdown
Contributor

@drona-gyawali drona-gyawali commented Apr 23, 2026

Description

This pr will provide credential-level visibility into IOC feeds by exposing a computed credential_count field and adding filtering support via min_credential_count and max_credential_count query parameters.

  1. Queryset enhancement
  • Annotate IOC queryset with:
    • credntial_count = Count("credentials", distinct=True)
  • Enables per-IOC credential activity tracking.
  1. Filtering support
  • Added query parameters:
    • min_credential_count
    • max_credential_count
  • Allows filtering IOCs based on credential interaction volume.
  1. API response update
  • credential_count is now included in JSON feed response.

Related issues

Closes: #1294
related: #1098

Please add related issues: the issues you are trying to solve as well as other issues that are important in the context of this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Chore (refactoring, dependency updates, CI/CD changes, code cleanup, docs-only changes).

Checklist

Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.

Formalities

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • I documented my code changes with docstrings and/or comments.
  • I have checked if my changes affect user-facing behavior that is described in the docs. If so, I also included an update to the wiki in the description of this PR.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

Review process

  • We encourage you to create a draft PR first, even when your changes are incomplete. This way you refine your code while we can track your progress and actively review and help.
  • If you think your draft PR is ready to be reviewed by the maintainers, click the corresponding button. Your draft PR will become a real PR.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem.
  • Every time you make changes to the PR and you think the work is done, you should explicitly ask for a review. After receiving a "change request", address the feedback and click "request re-review" next to the reviewer's profile picture at the top right.

Signed-off-by: Drona Raj Gyawali <dronarajgyawali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant