Skip to content

Upgrade to React version 19. Closes #801#1301

Merged
regulartim merged 10 commits intodevelopfrom
upgrade_react
May 4, 2026
Merged

Upgrade to React version 19. Closes #801#1301
regulartim merged 10 commits intodevelopfrom
upgrade_react

Conversation

@regulartim
Copy link
Copy Markdown
Member

@regulartim regulartim commented Apr 23, 2026

Description

Please include a short summary of the change. Don't just paste LLM output here.

Related issues

Closes #801

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Chore (refactoring, dependency updates, CI/CD changes, code cleanup, docs-only changes).

Checklist

Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.

Formalities

  • I have read and understood the rules about how to Contribute to this project.
  • I chose an appropriate title for the pull request in the form: <feature name>. Closes #999
  • My branch is based on develop.
  • The pull request is for the branch develop.
  • I have reviewed and verified any LLM-generated code included in this PR.

Docs and tests

  • I documented my code changes with docstrings and/or comments.
  • I have checked if my changes affect user-facing behavior that is described in the docs. If so, I also included an update to the wiki in the description of this PR.
  • Linter (Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved.
  • All the tests gave 0 errors.

GUI changes

Ignore this section if you did not make any changes to the GUI.

  • I have provided a screenshot of the result in the PR.
  • I have created new frontend tests for the new component or updated existing ones.

Review process

  • We encourage you to create a draft PR first, even when your changes are incomplete. This way you refine your code while we can track your progress and actively review and help.
  • If you think your draft PR is ready to be reviewed by the maintainers, click the corresponding button. Your draft PR will become a real PR.
  • If your changes decrease the overall tests coverage (you will know after the Codecov CI job is done), you should add the required tests to fix the problem.
  • Every time you make changes to the PR and you think the work is done, you should explicitly ask for a review. After receiving a "change request", address the feedback and click "request re-review" next to the reviewer's profile picture at the top right.

@regulartim regulartim changed the title Upgrade to React version 19 Upgrade to React version 19. Closes #801 Apr 23, 2026
@regulartim
Copy link
Copy Markdown
Member Author

@armoredvortex , @rootp1 , would you like to test and / or give feedback?

@regulartim regulartim marked this pull request as ready for review April 23, 2026 17:01
@rootp1
Copy link
Copy Markdown
Contributor

rootp1 commented Apr 23, 2026

@armoredvortex , @rootp1 , would you like to test and / or give feedback?

for sure, @regulartim.

Copy link
Copy Markdown
Contributor

@armoredvortex armoredvortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a minor visual regression on the feeds table in the column headings.
Image
This is probably due to gb-ui, not a dealbreaker.

.then((r) => r.json())
.then((json) => {
if (!cancelled) setGeoData(json);
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetch() is missing a ok and catch block.
Failed requests not handled.

@rootp1
Copy link
Copy Markdown
Contributor

rootp1 commented Apr 26, 2026

GreedyBear.mp4

Afaik the behaviour is same,
Can you go through the attached video to confirm
@regulartim @armoredvortex

@armoredvortex
Copy link
Copy Markdown
Contributor

GreedyBear.mp4

Afaik the behaviour is same, Can you go through the attached video to confirm @regulartim @armoredvortex

Yes, i have tested locally aswell and havent found any behavioral changes in any component.
Haven't had the time to go through the codebase of gb-ui yet 😅
For Greedybear, everything LGTM for now.

@regulartim
Copy link
Copy Markdown
Member Author

Thanks a lot @rootp1 @armoredvortex !

@regulartim regulartim merged commit 1436ced into develop May 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants