added the cleanup in emailVerfication#1308
Merged
regulartim merged 1 commit intoGreedyBear-Project:developfrom May 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix issue #1252 by adding missing useEffect cleanup logic in the EmailVerification component to prevent a scheduled setTimeout from firing after the effect is torn down.
Changes:
- Store the
setTimeoutID when scheduling the email verification call. - Clear the timeout in the
useEffectcleanup function when the effect is cleaned up.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added effect cleanup in
EmailVerificationcomponent by storing thesetTimeoutreturn value and clearing it in theuseEffectcleanup function.Type of change
Checklist
Formalities
Add effect cleanup in EmailVerification. Closes #[issue number]develop.develop.Docs and tests
Ruff) gave 0 errors.Closes issue #1252