refactor(cronjobs): migrate mass_scanners, firehol, and spamhaus_drop to HttpClient.#1309
Open
Prasad8830 wants to merge 3 commits intoGreedyBear-Project:developfrom
Open
refactor(cronjobs): migrate mass_scanners, firehol, and spamhaus_drop to HttpClient.#1309Prasad8830 wants to merge 3 commits intoGreedyBear-Project:developfrom
Prasad8830 wants to merge 3 commits intoGreedyBear-Project:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the second batch of standardising our cron jobs HTTP fetchers, as discussed in #1214.
It migrates the
mass_scanners,firehol, andspamhaus_dropendpoints to utilise the new centralisedHttpClientwrapper introduced in #1253. This refactor replaces ad-hocrequests.getcalls with the shared client, ensuring standardised error handling, built-in logging, and automatic retries for server errors.For
fireholandspamhaus_drop, the original explicittimeout=60argument was intentionally preserved to prevent large blocklist fetches from failing due to premature timeouts.Related issues
Type of change
Checklist
Please complete this checklist carefully. It helps guide your contribution and lets maintainers verify that all requirements are met.
Formalities
<feature name>. Closes #999develop(via the wrapper branch).develop.Docs and tests
Ruff) gave 0 errors. If you have correctly installed pre-commit, it runs these checks and makes these adjustments on your behalf.GUI changes
Ignore this section if you did not make any changes to the GUI.