Open
Conversation
…k() and removeBack()
…k() and removeBack()
…ckage names, Override toStringMethods(), tested with Driver class
…n DoublyLinkedIntList
…ger[] so class will support 0 as an index value and intialize the array to default null values
…ger[] so class will support 0 as an index value and intialize the array to default null values
…kage because I am out of time. The list classes are complete and function properly. I tested as I went along with the driver class. I have never written a fully functioning jUnit test class and I am new to the framework. That was written for the ArrayIntList class. I don't think I will be able to get much more accomplished before 5pm tomorrow night.
…error in LinkedIntList get().
…ixed toString() and size miss count within remove().
kendrickhang
reviewed
Feb 6, 2024
| */ | ||
| @Override | ||
| public Iterator<Integer> iterator() { | ||
| return null; |
Collaborator
There was a problem hiding this comment.
I see your iterator() method on the DoublyLinkedList class returns null. I believe that is a stub. It should return an instance of a new iterator object. If you look at the LinkedIntList (singly-linked list), you will see that you defined an iterator class (nested) that has implementations of next() and hasNext() methods -- and then in the iterator() method returned a new instance of that class. We need the same/similar here in DoublyLinkedList...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items ready for review:
All list classes are complete and function properly. I believe this is as far as I can get with this package because I am out of time. I tested as I went along with the driver class. I have never written a fully functioning jUnit test class and I am new to the framework. That was written for the ArrayIntList class. I don't think I will be able to get much more accomplished before 5pm tomorrow night.