fix[next]: apply cse in fuse_as_fieldop #2257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Sep 11, 2025
havogt
commented
Nov 26, 2025
src/gt4py/next/iterator/transforms/fixed_point_transformation.py
Outdated
Show resolved
Hide resolved
havogt
commented
Nov 27, 2025
| fuse_args, | ||
| uids=self.uids, | ||
| offset_provider_type=self.offset_provider_type, | ||
| enable_cse=True, |
Contributor
Author
There was a problem hiding this comment.
I added this option mainly for testing, but now we could disable it here and we wouldn't have to pass the offset_provider_type. Not sure what to do...
tehrengruber
approved these changes
Nov 27, 2025
| # instead of an as_fieldop | ||
| if cpm.is_call_to( | ||
| node, ("lift", "shift", "reduce", "map_", "index") | ||
| node, ("lift", "shift", "neighbors", "reduce", "map_", "index") |
Contributor
There was a problem hiding this comment.
Could you extend the comment above to document why neighbors should not be collected.
Contributor
Author
There was a problem hiding this comment.
Wondering if this can be undone, after unroll_reduce #2267 ?
tehrengruber
approved these changes
Dec 3, 2025
Contributor
Author
|
running icon4py ci here C2SM/icon4py#869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies cse in fuse_as_fieldop to simplify the tree in nested repeated operations.