Easy new encounters#443
Open
IPDTFE wants to merge 1 commit intoGrognardsFromHell:masterfrom
Open
Conversation
Contributor
|
Welcome back! TBH if you're just going to outright duplicate the Co8 random encounters file, and assume in your script it's a Co8 installation, you may as well make it a Co8 mod (perhaps an override file). Perhaps it would be better to run the original script first, and do a check on the encounter ID. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm back after all this time. I started a new branch because I was having issues with the older one.
It is the same idea as the other currently open pull request, users can now create additional road encounters and sleep encounters by adding a file in a folder called encounterpacks located in their main TOEE directory. The folder's structure is fairly simple, I've attached an example.
encounterpacks.zip
The program works by calling expanded_encounters (my script) instead of random_encounter in python_integration_encounter.cpp.
expanded_encounters mimicks pretty much all of random_encounter's co8 version, limitations included.
If the user doesn't have a directory called encounterpacks in the TOEE folder or if co8 is not installed, random_encounter is immediately called by my script, ensuring normal functionalities.
Sleep encounters can be only called on one type of unit, but other units can be added through the reinforcements method.
Travel encounters work with RE_entry as normal.
Currently doesn't support linux I guess, haven't looked into proper path handling so it will behave as if there were no encounterpacks folder.
It should now fit most of the criteria that were set for me after the last upload, let me know if anything needs to change again.
As far as I've tested it works on vanilla and Co8 but my vanilla installation had a lot of separate issues for some reason so it might be worth rechecking on a different computer.
edit: updated the encounter pack example