Make more widespread use of D20CAF type rather than just integers#938
Draft
dolio wants to merge 1 commit intoGrognardsFromHell:masterfrom
Draft
Make more widespread use of D20CAF type rather than just integers#938dolio wants to merge 1 commit intoGrognardsFromHell:masterfrom
dolio wants to merge 1 commit intoGrognardsFromHell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't change any logic. It just tries to make using the
D20CAFtype better without circumventing type checking.D20Actnhave aD20CAFfield for flags, rather than just an integer.D20CAFthat maintain the type instead of auto-converting touint32_t.For python, I elected to keep things as integers, and changed the
flagsfield to usedef_propertyto do the conversion. This is because python enums don't work as well with flag types, at least in python 2.The motivation for this was annoyance when porting more grenade functions, having to cast things back to
D20CAFand whatnot.