Skip to content

Replace deprecated appearanceWhenContainedIn with modern API #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soushi-arakawa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated appearanceWhenContainedIn with modern API #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions Classes/ios/UIBarButtonItem+FlatUI.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,30 @@ + (void) configureFlatButtonsWithColor:(UIColor *) color
highlightedColor:(UIColor *)highlightedColor
cornerRadius:(CGFloat) cornerRadius
whenContainedIn:(Class <UIAppearanceContainer>)containerClass, ... {
va_list vl;
va_start(vl, containerClass);
id appearance = [UIBarButtonItem appearanceWhenContainedIn:containerClass, nil];
va_end(vl);
[UIBarButtonItem configureItemOrProxy:appearance forFlatButtonWithColor:color highlightedColor:highlightedColor cornerRadius:cornerRadius];
NSMutableArray *containerClasses = [NSMutableArray array];
if (containerClass) {
[containerClasses addObject:containerClass];

va_list vl;
va_start(vl, containerClass);
Class arg;
while ((arg = va_arg(vl, Class))) {
[containerClasses addObject:arg];
}
va_end(vl);
}

id appearance;
if (@available(iOS 9.0, *)) {
appearance = [UIBarButtonItem appearanceWhenContainedInInstancesOfClasses:containerClasses];
} else {
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
appearance = [UIBarButtonItem appearanceWhenContainedIn:containerClass, nil];
#pragma clang diagnostic pop
}

[UIBarButtonItem configureItemOrProxy:appearance forFlatButtonWithColor:color highlightedColor:highlightedColor cornerRadius:cornerRadius];
}

// only used pre-ios7
Expand Down