Modernize button inset handling and suppress deprecation warnings#206
Open
soushi-arakawa wants to merge 1 commit intoGrouper:masterfrom
Open
Modernize button inset handling and suppress deprecation warnings#206soushi-arakawa wants to merge 1 commit intoGrouper:masterfrom
soushi-arakawa wants to merge 1 commit intoGrouper:masterfrom
Conversation
Wrapped setTitleEdgeInsets: override with #pragma clang diagnostic ignored "-Wdeprecated-implementations" to resolve iOS 15+ warnings. Updated initWithFrame: and initWithCoder: to safely capture default insets from both legacy properties and modern UIButtonConfiguration. Synchronized shadow-based inset calculations with UIButtonConfiguration.contentInsets on iOS 15+. Ensured consistent "pressed" visual effects across all initialization paths while maintaining Zero-Warning build status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped setTitleEdgeInsets: override with #pragma clang diagnostic ignored "-Wdeprecated-implementations" to resolve iOS 15+ warnings.
Updated initWithFrame: and initWithCoder: to safely capture default insets from both legacy properties and modern UIButtonConfiguration.
Synchronized shadow-based inset calculations with UIButtonConfiguration.contentInsets on iOS 15+.
Ensured consistent "pressed" visual effects across all initialization paths while maintaining Zero-Warning build status.