Skip to content

Apply fixes from CodeFactor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codefactor-io wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply fixes from CodeFactor #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions AddShapeEffect/AddShapeEffectProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Collections.Immutable;
using System.Collections.Immutable;
using System.Numerics;
using AddShapeEffect.ForVideoEffectChain;
using Vortice.Direct2D1;
Expand Down Expand Up @@ -73,7 +73,6 @@ public DrawDescription Update(EffectDescription effectDescription)
DrawDescription descAfterChain = effectDescription.DrawDescription;

if (currentInput == null) return effectDescription.DrawDescription;

{
var shapeParameter = item.ShapeParameter;
if (isFirst || this.shapeParameter != shapeParameter)
Expand Down Expand Up @@ -129,8 +128,8 @@ public DrawDescription Update(EffectDescription effectDescription)
float baseL = x - baseHalfWidth;
float baseR = x + baseHalfWidth;

float targetL = item.PinLeft ? (-inputWidth / 2f + leftMargin) : baseL;
float targetR = item.PinRight ? (inputWidth / 2f - rightMargin) : baseR;
float targetL = item.PinLeft ? ((-inputWidth / 2f) + leftMargin) : baseL;
float targetR = item.PinRight ? ((inputWidth / 2f) - rightMargin) : baseR;

float finalWidth = targetR - targetL;
float finalScaleX = (shapeWidth > 0) ? (finalWidth / shapeWidth) : 0;
Expand All @@ -140,8 +139,8 @@ public DrawDescription Update(EffectDescription effectDescription)
float baseT = y - baseHalfHeight;
float baseB = y + baseHalfHeight;

float targetT = item.PinTop ? (-inputHeight / 2f + topMargin) : baseT;
float targetB = item.PinBottom ? (inputHeight / 2f - bottomMargin) : baseB;
float targetT = item.PinTop ? ((-inputHeight / 2f) + topMargin) : baseT;
float targetB = item.PinBottom ? ((inputHeight / 2f) - bottomMargin) : baseB;

float finalHeight = targetB - targetT;
float finalScaleY = (shapeHeight > 0) ? (finalHeight / shapeHeight) : 0;
Expand Down