Skip to content

Enable type check in tests for extensions#856

Merged
YanVugenfirer merged 1 commit intoHCK-CI:masterfrom
kostyanf14:ext-type
Feb 1, 2026
Merged

Enable type check in tests for extensions#856
YanVugenfirer merged 1 commit intoHCK-CI:masterfrom
kostyanf14:ext-type

Conversation

@kostyanf14
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the system by integrating type checking for HCKTest extension configuration files. By mapping these JSON files to their respective AutoHCK::Models::Extension model, the system can now validate their structure and content, preventing potential runtime errors and ensuring data integrity.

Highlights

  • Type Checking: Extended type checking to include JSON configuration files for HCKTest extensions.
  • File Mapping: Added a new entry in spec/srb_json_load_spec.rb to map lib/engines/hcktest/extensions/*.json to the AutoHCK::Models::Extension class.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the JSON type-checking spec to include extension configuration JSON files so they are validated via Sorbet model loading during test runs.

Changes:

  • Adds ./lib/engines/hcktest/extensions/*.json to JSON_TYPES_MAP and maps it to AutoHCK::Models::Extension.
  • Updates the preceding hash entry to include a trailing comma for the newly added entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables type checking in tests for Extension model JSON files. The change is correct, but I've suggested sorting the entries in the JSON_TYPES_MAP hash alphabetically to improve readability and maintainability.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
@kostyanf14
Copy link
Contributor Author

rebased to check the latest extension

@YanVugenfirer YanVugenfirer merged commit a6fe32f into HCK-CI:master Feb 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants