Skip to content

Add NDIS65_ndprot683_fix for several kits #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kostyanf14 merged 1 commit into from
Feb 2, 2026
Merged

Add NDIS65_ndprot683_fix for several kits #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/engines/hckinstall/kits/HLK11_24H2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"download_url": "https://go.microsoft.com/fwlink/?linkid=2335862",
"extra_software": [
"winfsp"
"winfsp",
"NDIS65_ndprot683_fix"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

],
"studio_platform": "Win2022x64",
"name": "HLK11_24H2"
Expand Down
3 changes: 2 additions & 1 deletion lib/engines/hckinstall/kits/HLK11_25H2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"download_url": "https://go.microsoft.com/fwlink/?linkid=2335804",
"sha256": "b970b8f8dd2af850e951a9dae6278bb16b6e63ad25caa8525be9441567248809",
"extra_software": [
"winfsp"
"winfsp",
"NDIS65_ndprot683_fix"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

],
"studio_platform": "Win2022x64",
"name": "HLK11_25H2"
Expand Down
3 changes: 2 additions & 1 deletion lib/engines/hckinstall/kits/HLK2025.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"extra_software": [
"Test-NETHLK",
"winfsp",
"RoMetadataDll"
"RoMetadataDll",
"NDIS65_ndprot683_fix"
Copy link

@gemini-code-assist gemini-code-assist bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

],
"studio_platform": "Win2022x64",
"name": "HLK2025"
Expand Down
Loading