Add NDIS65_ndprot683_fix for several kits

[kostyanf14]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a specific NDIS (Network Driver Interface Specification) fix, NDIS65_ndprot683_fix, into the configuration for multiple versions of the Hardware Lab Kit (HLK). By adding this component to the extra_software list in the respective JSON files, it ensures that these HLK environments automatically provision the necessary fix, likely addressing a known network-related issue or enhancing compatibility for hardware testing.

Highlights

• HLK11_24H2 Configuration Update: The HLK11_24H2.json configuration file has been updated to include NDIS65_ndprot683_fix in its extra_software list.
• HLK11_25H2 Configuration Update: The HLK11_25H2.json configuration file has been updated to include NDIS65_ndprot683_fix in its extra_software list.
• HLK2025 Configuration Update: The HLK2025.json configuration file has been updated to include NDIS65_ndprot683_fix in its extra_software list.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds NDIS65_ndprot683_fix as extra software for several HLK kits. While the changes to the JSON configuration files are correct, the pull request seems to be incomplete. It's missing the necessary configuration files for the newly added NDIS65_ndprot683_fix software. Without these files, the application will fail at runtime when it tries to prepare the extra software packages. I've added comments to each modified file pointing out this critical issue.

[gemini-code-assist]

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

[gemini-code-assist]

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

[gemini-code-assist]

Adding "NDIS65_ndprot683_fix" to extra_software requires a corresponding configuration for it. The ExtraSoftwareManager will look for a configuration file (e.g., config.json) in a directory named NDIS65_ndprot683_fix under the extra_software path. This PR appears to be missing this configuration, which will likely cause a runtime failure when read_config in lib/auxiliary/extra_software/manager.rb is called. Please add the necessary configuration for this new software.

[Copilot]

Pull request overview

This PR adds the NDIS65_ndprot683_fix extra software package to selected HLK 2025/Win11 kits so that the corresponding NDIS 6.5 protocol fix is automatically prepared and installed alongside existing extras.

Changes:

• Update HLK2025 kit configuration to include NDIS65_ndprot683_fix in its extra_software list.
• Update HLK11_25H2 kit configuration to include NDIS65_ndprot683_fix in its extra_software list after winfsp.
• Update HLK11_24H2 kit configuration to include NDIS65_ndprot683_fix in its extra_software list after winfsp.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
lib/engines/hckinstall/kits/HLK2025.json	Adds NDIS65_ndprot683_fix to the HLK2025 kit’s extra_software array, ensuring this fix is prepared and copied to setup scripts for that kit.
lib/engines/hckinstall/kits/HLK11_25H2.json	Extends the extra_software list for HLK11_25H2 to include NDIS65_ndprot683_fix alongside winfsp.
lib/engines/hckinstall/kits/HLK11_24H2.json	Extends the extra_software list for HLK11_24H2 to include NDIS65_ndprot683_fix alongside winfsp.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.