RHELMISC-2863: Try to restart CI process when start_studio_service fails#61
Merged
kostyanf14 merged 1 commit intomasterfrom Feb 25, 2025
Conversation
Jedoku
changed the title
Jedoku
force-pushed
the
RHELMISC-2863-Try-to-restart-CI-process-when-start-studio-service-fails
branch
from
b092cba to
6a94d0f
Compare
kostyanf14
requested changes
Feb 12, 2025
Comment on lines
178
to
189
| def start_studio_service(service_name) | ||
| run("Start-Service #{service_name}") | ||
| retries = 0 | ||
| timeout = 30 | ||
| begin | ||
| run("Start-Service #{service_name}") | ||
| rescue WinrmPSRunError => e | ||
| raise e unless (retries += 1) < 3 | ||
|
|
||
| logger('warn', "#{e.message} Retrying in #{timeout} seconds...") | ||
| sleep(timeout) | ||
|
|
||
| retry | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Move timeout and 3(max retry count) to global constant
No need for an extra begin/end block just use retries ||= 0
Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
Jedoku
force-pushed
the
RHELMISC-2863-Try-to-restart-CI-process-when-start-studio-service-fails
branch
from
6a94d0f to
d660ff5
Compare
akihikodaki
approved these changes
Feb 19, 2025
kostyanf14
approved these changes
Feb 25, 2025
kostyanf14
approved these changes
Feb 25, 2025
kostyanf14
deleted the
RHELMISC-2863-Try-to-restart-CI-process-when-start-studio-service-fails
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.