Feature hotspot creation by diyaseb285 · Pull Request #15 · HEATRobotics/EMBR-Web

diyaseb285 · 2025-11-16T21:19:16Z

Summary

Provide a short, clear description of what this PR does and why.
Created a new MySQL table for hotspots, where one hotspot can be linked to many different temperatures. Added an insertHotspotData() function that will take data from the position table and take the latest position for the bot of focus, storing that one position value in the hotspot table. Combined the latest GPS coordinates with 10 temperature values, and sent the hotspot data back to the server file.

Related Task

Closes Create and store hotspots in db based off of incoming data from radio

Type of Change

Select all that apply:

📄 Documentation

All of the following applicable documentation changes were added
- How to connect the new device and wiring
- Links to external documentation on the device
- Any other setup or important information
No documentation changes required

🧪 Testing

Describe how this change was tested.
Include commands or steps used, and confirm successful results.
In init.sql, after I created the hotspot table, which has a one-to-many relationship with the botID. I tested the code, but the hotspot table would not show up, so I added: FOREIGN KEY (hotspotID) REFERENCES hotspot(hotspotID) ON DELETE CASCADE under the temperature table so that it accounted for the fact that one hotspot could have many temperature values. I also altered the storeMavlinkData(data) function in server.mjs so that the data type 'hotspot_data' was accounted for.

Image of GUI change (if applicable)

Paste an image of the GUI change.

✅ Pre-Merge Checklist

PR started as a Draft
Linked to correct Notion Task
Branch includes updated documentation
Code reviewed by peer
Ready for final review by Software Lead
All tests and builds pass
Notion task updated to Ready for Review

🧾 Notes (Optional)

Add any context, screenshots, or known issues reviewers should know about.

…cords. Created new hotspot table that has one-to-many relationship with temperature values. Many temp values link to one hotspot

…ion table and take the latest position for the bot of focus, storing that one position value into the hotspot table.

…he hotspot data back to server file.

… table since it should be linked to bot and hotspot in order for hotspot table to show up as a MySQL table

…ta type

…ad of every 5 seconds. Simulator updates between position and temperature data

…ta when the bot's stopped (velocity = 0), position data is sent at all times

mrichards03

Good work!

mrichards03 · 2026-02-28T19:58:23Z

+		//infer missionID from the bot if it is missing
+		if(data.missionID ==null){
+			const missionID =await getActiveMissionIdForBot(conn, data.botID);
+			data.missionID =missionID ??null; // if no active mission, set to null and let it be handled by the database constraints (if necessary) or just have battery data without a mission association


No need for mission data for battery data or position data. Can be removed from insert method and remove missionid from init.sql for battery table and position table.

mrichards03 · 2026-02-28T20:05:39Z

+		conn = await pool.getConnection();
+
+		// If missionID not provided, try to find an active mission for this bot
+		let missionID = data.missionID ?? null;


data will never contain mission id, right? the robot won't be sending mission id in the temperature message so you need to query it from the db. No point looking for data.missionId if it's never populated

mrichards03 · 2026-02-28T20:08:52Z

+			const [missionRows] = await conn.execute(
+				`SELECT DISTINCT m.missionID AS missionID
+				 FROM mission m
+				 JOIN bot_mission_assignment bma ON m.missionID = bma.missionID
+				 WHERE bma.botID = ? AND m.timeStart IS NOT NULL AND m.timeEnd IS NULL
+				 LIMIT 1`,
+				[data.botID]
+			);
+			missionID = missionRows[0] ? missionRows[0].missionID : null;
+		}


why do you have this but also a method (getActiveMissionIdForBot) that does the same thing? You should use the method here

mrichards03 · 2026-02-28T20:11:09Z

+			data.latitude,
+			data.longitude,
+			data.altitude ?? null,
+			data.notes ?? null,


Again, there's not going to be notes in the temperature message so just insert null otherwise the code is misleading

mrichards03 · 2026-02-28T20:11:58Z

  ardupilotmega,
 } = mavlink;
+const latestGPS = {};
+const tempVals = {};


this isn't used

mrichards03 · 2026-02-28T20:15:20Z

  NOTE: data format for simulated battery data is arbitrary; i.e. the keys do not correspond to actual incoming data, because battery percentage is new and I do not yet know the format in which battery % will be sent by the bot. Once format is finalized, function processBatteryMessage() as well as the 'battery' table in DB must both be changed, and the battery simulation part of the function will break unless also changed accordingly.
 */
+
+let simStarted = false;


why was this added? SimulateMavlinkData() is only called once on the index page so I don't see how it would ever be called again after simulation is already started? Did you encounter that as a problem?

mrichards03 · 2026-02-28T21:08:43Z

  let botTempData = [];

-  for (let i = 0; i < NUM_SIMULATED_BOTS; i++) {
+  let temperatureTick = false; //start with GPS so latestGPS is populated before temp data


mrichards03 · 2026-02-28T22:26:54Z

        const allBatteryData = await getAllBatteryData();
        io.emit('battery:update', allBatteryData);
    }
+    //TODO: insert hotspot data, don't worry about io.emit for now


remove this comment

…ics/EMBR-Web into featureHotspotCreation

…lation

diyaseb285 added 5 commits November 13, 2025 18:10

removed bot records in temperature table, switched out for hotspot re…

16c7bb4

…cords. Created new hotspot table that has one-to-many relationship with temperature values. Many temp values link to one hotspot

added insertHotspotData() function that will take data from the posit…

e7b648f

…ion table and take the latest position for the bot of focus, storing that one position value into the hotspot table.

combine the latest GPS coordinates with 10 temperature values. Send t…

a473e9d

…he hotspot data back to server file.

Needed to add one-to-many relationship statement into the temperature…

2b3821b

… table since it should be linked to bot and hotspot in order for hotspot table to show up as a MySQL table

Made it so that storeMavlinkData() function will take in 'hotspot' da…

f41c4da

…ta type

diyaseb285 assigned mrichards03, amrasilmy44-dotcom and diyaseb285 Nov 16, 2025

diyaseb285 added 2 commits January 5, 2026 10:15

Updates the mavlink data simulator by sending data every second inste…

29a8cb9

…ad of every 5 seconds. Simulator updates between position and temperature data

small errors fixed in MYSQL table, and server file

5cfa53d

diyaseb285 marked this pull request as draft January 17, 2026 01:27

mrichards03 and others added 7 commits January 24, 2026 12:13

Merge branch 'dev' into featureHotspotCreation

6deaeef

merge conflict fix

ed9d50f

more merge conflict fixes

f8964dc

creating & inserting hotspots

cc147f5

Update database.service.mjs

c5c5ce8

Update database.service.mjs

fe829ee

update "simulateMavlinkData" function to only simulate temperature da…

846b96c

…ta when the bot's stopped (velocity = 0), position data is sent at all times

diyaseb285 marked this pull request as ready for review February 14, 2026 05:20

Update database.service.mjs

a0447f0

mrichards03 requested changes Feb 28, 2026

View reviewed changes

MeelaParker and others added 5 commits March 5, 2026 12:54

addressed comments on PR for MacKenzie

5a743f3

addressed comments for backend hotspot code

bfea330

Merge branch 'featureHotspotCreation' of https://github.com/HEATRobot…

6df9034

…ics/EMBR-Web into featureHotspotCreation

fixes made to show the hotspot data was created when running the simu…

9852323

…lation

removed assumption that missionID exists. Query mission from db

a68ca83

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature hotspot creation#15

Feature hotspot creation#15
diyaseb285 wants to merge 20 commits intodevfrom
featureHotspotCreation

diyaseb285 commented Nov 16, 2025

Uh oh!

mrichards03 left a comment

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

mrichards03 Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

diyaseb285 commented Nov 16, 2025

Summary

Related Task

Type of Change

📄 Documentation

🧪 Testing

Image of GUI change (if applicable)

✅ Pre-Merge Checklist

🧾 Notes (Optional)

Uh oh!

mrichards03 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants