Open
Conversation
Member
Author
|
@simone-romiti this is required to make the first fit pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a proposal for now and a real implementation would take some time and effort in order to provide the full functionality including, perhaps, even plotting support.
By relaxing the condition on the lengths of
xandy(requiring the former to be divisible by the latter),bootstrap.nlsfitin principle immediately supports fits in more than one dimension by simply concatenating the different X variables that one wants to use and writing an appropriate fit function which indexes into these (the necessary starting indices might be passed as a vector themselves, for example).