fix: improve core stability and optional MCP websocket dependency handling#21
Open
wul48527-code wants to merge 3 commits intoHKUDS:mainfrom
Open
fix: improve core stability and optional MCP websocket dependency handling#21wul48527-code wants to merge 3 commits intoHKUDS:mainfrom
wul48527-code wants to merge 3 commits intoHKUDS:mainfrom
Conversation
Contributor
Author
|
补充测试说明(便于 review):
本 PR 关注点:
如有需要,我可以把任意一个修复点再拆成更小 commit 方便逐个审阅。 |
Collaborator
|
Thanks for the thorough investigation. We've reviewed each item and cherry-picked the two changes that address real bugs into main:
You're credited as co-author on both fixes. Changes we're not including:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR addresses several stability issues found during local usage:
Changes
websocketsis missing.max_iterationsis passed in no-skill execution path.Tests
Added/updated regression tests:
tests/test_tool_layer.pytests/test_mcp_server.pytests/test_dashboard_server.pytests/test_mcp_connectors_optional.pyLocal validation:
py -3.13 -m unittest discover -s tests -vCompatibility
The changes are backward compatible and primarily improve robustness and error handling.