Skip to content

Conversation

@tuomas-lindell
Copy link

Proposed Changes

  • changed waiting picto to standing, after this change sitting picto is used only for interlining legs

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

AB#336 fix transit leg end fill color
@tuomas-lindell tuomas-lindell changed the base branch from v3 to next December 11, 2025 07:51
Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but let's improve the current setup a bit:

  • rename icon_wait as icon_wait_sitting, and icon_navigation_wait as icon_wait_standing
  • rename references to these icons respectively
  • icon_wait_sitting renders smaller than other respective icons. Extra padding should be removed. I can do this if you are not familiar with the required tools.
  • icon_wait_sitting seems to have a hard coded fill color. Color should be set using css styles of the content which renders the icon. Most likely it is enough to remove color definition from svg.

@tuomas-lindell tuomas-lindell force-pushed the AB#137-Improve-how-transfers-are-displayed branch from c3375b0 to 68ec234 Compare December 11, 2025 11:46
Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there seems to be some confusion. icon_wait_sitting seems to render a standing person. In navigation components, both icons are referred, although only the standing one should be used.

InterlineInfo.js refers to original icon_wait. icon_wait should be renamed as icon_wait_sitting, because it indeed shows a sitting person.

In sprite sheets, icon_navigation which has nothing to do with waiting was renamed to something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants