Skip to content

De-duplicated fixed-point limits definition#129

Open
rubenhorn wants to merge 4 commits intomasterfrom
deduplicate-fixed-point-code-WIP
Open

De-duplicated fixed-point limits definition#129
rubenhorn wants to merge 4 commits intomasterfrom
deduplicate-fixed-point-code-WIP

Conversation

@rubenhorn
Copy link
Copy Markdown
Contributor

(As mentioned in #125)

@rubenhorn rubenhorn requested a review from Thinkpiet February 12, 2026 15:16
Copy link
Copy Markdown
Member

@Thinkpiet Thinkpiet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe it should also be used in ComputeMeanVelocityMapping?

@rubenhorn
Copy link
Copy Markdown
Contributor Author

ComputeMeanVelocityMapping

ComputeMeanVelocityMapping.h currently does not use fixed-point math.
Do you mean it should be part of the benchmark?

@Thinkpiet
Copy link
Copy Markdown
Member

Sorry for ambiguity. I meant this, not this

@rubenhorn rubenhorn requested a review from Thinkpiet February 14, 2026 21:13
@rubenhorn rubenhorn marked this pull request as draft February 15, 2026 14:48
@rubenhorn rubenhorn marked this pull request as ready for review February 15, 2026 14:48
@github-actions
Copy link
Copy Markdown

Sufficient test coverage for changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants