Skip to content

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Jul 31, 2025

Renamed and moved multiple SQL files from sql/ to migrated_sql/.

To merge after HTTPArchive/dataform#141.

@max-ostapenko max-ostapenko changed the title Remove migrated reports before next crux/crawl completion Switch off migrated reports before next crux/crawl completion Jul 31, 2025
@max-ostapenko
Copy link
Contributor Author

@tunetheweb please have a look.
I'm not done with migration, but once ready - we'll switch some reports off.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But, given that we've already had problems with this month's crawl, let's run the known way one more time and switch over for September.

@max-ostapenko
Copy link
Contributor Author

@tunetheweb please let me know the concerns. I don't understand an issue migrating this month.
And actually wanted to switch histogram reports today (as don't need retrospective data to append to).

@tunetheweb
Copy link
Member

No real concerns. Just we're running late this month so didn't really wanna add any more change in case this goes wrong too. But not a biggy if you have reason to want to do this now.

Also can you copy the sql/.sqlfluff file to migrated_sql folder so linting still works? Though hopefully, as you say, this will all be gone soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants