dbstore: update rfid encoding for esp-rfid v2 firmware#195
Merged
Conversation
The old firmware manged the rfid string. v2 firmware has resolved this issue. This commit removes the legacy encoding of the rfid string in favor of a "correct" implementation. It also adds tests for two known buggy rfid values. Signed-off-by: Peter Maxwell Warasila <madmaxwell@soundcomesout.com>
pacna
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The old firmware manged the rfid string. v2 firmware has resolved this issue. This commit removes the legacy encoding of the rfid string in favor of a "correct" implementation. It also adds tests for two known buggy rfid values.
Type of change
Please delete options that are not relevant.
Checklist:
Please put an
xin the boxes that apply. You can also fill these out after creating the PR.