Skip to content

Update services.py #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update services.py #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions styleguide_example/common/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
from django.utils import timezone

from styleguide_example.common.types import DjangoModelType

from rest_framework.exceptions import ValidationError as DRFValidationError
from django.core.exceptions import ValidationError

def model_update(
*, instance: DjangoModelType, fields: List[str], data: Dict[str, Any], auto_updated_at=True
Expand Down Expand Up @@ -69,13 +70,14 @@ def user_update(*, user: User, data) -> User:
if "updated_at" in model_fields and "updated_at" not in update_fields:
update_fields.append("updated_at")
instance.updated_at = timezone.now() # type: ignore

instance.full_clean()
# Update only the fields that are meant to be updated.
# Django docs reference:
# https://docs.djangoproject.com/en/dev/ref/models/instances/#specifying-which-fields-to-save
instance.save(update_fields=update_fields)

try:
instance.full_clean()
instance.save(update_fields=update_fields)

except ValidationError as e:

raise DRFValidationError(e.message_dict)

for field_name, value in m2m_data.items():
related_manager = getattr(instance, field_name)
related_manager.set(value)
Expand Down