Conversation
|
By header I now realize I meant navbar. |
|
Other pull request (#114) got merged, so feel free to update this one. git checkout center-header
git fetch origin
git merge origin/gh-pagesAlso, mind including a screenshot with the new look? |
…nto center-header
|
Just looking at the changes to the CSS again, I'm a bit confused...it shouldn't take that many new styles to center the nav bar. Is there more to it than that? Also, can we move what's necessary to the 'base' or an even more specific 'nav' file? |
|
Yes I'll work on this. I added the .navbar selector in the style.scss file, but didn't touch the base.scss file. I only made one new style, but as I'm new to this, not sure what you are seeing, and if something else has changed that I have not noticed. The first commit I made (2fac62f) shows the only thing I changed. Then I fixed the merge conflict and changed the css selector back to the original class name because the other pull request with the HTML 5 tags hadn't been merged yet. Sorry still learning to code, and haven't done much HTML or CSS yet. |


@afeld @orta
I worked on fixing a different issue earlier for using HTML 5 semantic tags, and then worked on centering the header (only because I thought it may look nice). I was using the HTML 5 semantic tag, but because that's in a separate pull request which hasn't been merged I had to go back on this branch and change the css to reference the class name
.navbarinstead of the tag namenav.