-
Notifications
You must be signed in to change notification settings - Fork 192
Additional labeling and clarifying of Goddard code, particularly renderer.c
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop/3.0.0
Are you sure you want to change the base?
Conversation
gheskett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These seem like good changes, obviously this code still needs a lot more cleanup but this is a good start.
gheskett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mind merging this, so long as the conflicts are resolved.
This pull request renames many Goddard functions and variables to be more descriptive. A few functions and variables do not have a discernible function, as they are only used as part of incomplete, unused functions. While I could have left these as-is, I took the liberty of giving them names anyway, if only for improving the human readability of the code. I have also added more
UNUSEDtags where appropriate. Lastly, some comments were left explaining the functionality of previously undocumented functions, at least where I felt reasonably confident I understood what the function was doing.No changes to the behavior of the Goddard code have been made. In the case of
gd_dl_rot_matrix(previouslyfunc_8019F2C4), minor changes to how the function uses its arguments have been made for the sake of clarity.gd_dl_rot_matrixis only called during a specific switch statement in thedraw_shapefunction indraw_objects.c. Previously, the values 120, 121, and 122 were passed to represent the X, Y, and Z axes, respectively. Confusingly, 120 was then subtracted from this passed value in the function, meaning that it was essentially passing 0, 1, and 2 with extra steps. This change should have no effect on the behavior of the program.This is by no means a comprehensive PR. Hopefully, further labeling will follow.