Skip to content

Conversation

@mountainflaw
Copy link
Contributor

@mountainflaw mountainflaw commented Jul 3, 2024

The goal of this is to combine #789 and #764, while also moving microcode config from the makefile to config_graphics.h

@mountainflaw mountainflaw requested a review from gheskett as a code owner July 3, 2024 16:20
@gheskett gheskett added enhancement New feature or request monkaS monkaS cleanup Removal of useless or bloat code/features labels Jul 4, 2024
@gheskett gheskett added this to the 3.0 milestone Jul 4, 2024
@gheskett gheskett reopened this Jul 29, 2025
@github-project-automation github-project-automation bot moved this from Done to Needs Review in 3.0 (Major Feature Update) Jul 29, 2025
@BeverlyBean
Copy link

BeverlyBean commented Jul 29, 2025

if ex3 is still subject to changes then shouldn't this go into it's own develop branch

@gheskett
Copy link
Collaborator

gheskett commented Jul 29, 2025

if ex3 is still subject to changes then shouldn't this go into it's own develop branch

Probably not, it'll cause mayhem with disconnected feature branches if we have two split major branches (sporting a 2.4 branch for smaller changes is already painful enough)

@mountainflaw
Copy link
Contributor Author

ready

@mountainflaw
Copy link
Contributor Author

mountainflaw commented Aug 2, 2025

rundown to people just now reviewing:

  • removes s2dex engine + microcode
  • removes hvqm microcode + code
  • removes ique include directory because it's 1:1 with the n64 one
  • removes every microcode except f3dzex2 non, and adds f3dex3 + the cpu code (cameraworld, required changes, optional profiler)
  • microcode is now a config in include/config_graphics.h
  • adds an f3dex3-exclusive lighting engine
  • removes armips because the output for it was not being used anyways
  • removes various other leftovers from ultrasm64's microcode setup that were not being used
  • reintroduces rsp.s from decomp, except with much better formatting to allow for easier abi changing

bonuses:

  • fixes goddard cfb garbage on boot
  • optimized init_z_buffer to not waste an rdp command on frames where the zbuffer is not cleared
  • instant input is a local define (still enabled by default)
  • TARGET_N64 is dead in the makefile because it's dumb for a codebase that ONLY targets n64
  • updates the face demo to use vertex specular lighting with f3dex3 enabled

Copy link
Collaborator

@aglab2 aglab2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@BeverlyBean
Copy link

im arthurtilly and i approve this pr

@mountainflaw
Copy link
Contributor Author

it is time to review #816

1 similar comment
@mountainflaw
Copy link
Contributor Author

it is time to review #816

* This feature is not available for use with F3DEX3.
*/

// #define ENABLE_LINE_UCODE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is there any legitimate reason to not just ship this by default with EX2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean it would be an extra 8 KB of RAM wasted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is 8kb really worth an entire config define? That's 2 textures.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not just in the makefile isnt that where it was before

@github-project-automation github-project-automation bot moved this from Needs Review to In progress in 3.0 (Major Feature Update) Aug 12, 2025
@mountainflaw
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Removal of useless or bloat code/features enhancement New feature or request monkaS monkaS

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

7 participants