-
Notifications
You must be signed in to change notification settings - Fork 192
3.0 - Microcode overhaul #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop/3.0.0
Are you sure you want to change the base?
Conversation
|
if ex3 is still subject to changes then shouldn't this go into it's own |
Probably not, it'll cause mayhem with disconnected feature branches if we have two split major branches (sporting a 2.4 branch for smaller changes is already painful enough) |
|
ready |
7f666f2 to
da9c5ca
Compare
|
rundown to people just now reviewing:
bonuses:
|
aglab2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
|
im arthurtilly and i approve this pr |
|
it is time to review #816 |
1 similar comment
|
it is time to review #816 |
| * This feature is not available for use with F3DEX3. | ||
| */ | ||
|
|
||
| // #define ENABLE_LINE_UCODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, is there any legitimate reason to not just ship this by default with EX2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it would be an extra 8 KB of RAM wasted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is 8kb really worth an entire config define? That's 2 textures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this not just in the makefile isnt that where it was before
|
fixed |
The goal of this is to combine #789 and #764, while also moving microcode config from the makefile to config_graphics.h