Feat/dark mode chart colors#669
Open
theFirstCodeManiac wants to merge 2 commits intoHahfyeex:Defaultfrom
Open
Conversation
|
@theFirstCodeManiac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #589
Description
This PR implements theme-aware chart colors for all Recharts components, ensuring proper visibility and consistency across both dark and light modes. It removes hardcoded color values and introduces a dynamic system that responds instantly to theme changes.
Type of Change
Changes Made
useChartColorshook to provide theme-based color palettesChartThemeProviderfor centralized color managementMutationObserverto detect and respond to theme changes in real-timeTesting
Checklist
Screenshots (if applicable)
N/A
Additional Notes
This implementation ensures charts remain accessible, visually consistent, and fully responsive to theme changes without introducing performance overhead.