Open
Conversation
Contributor
|
There is already a flag to disable timeouts altogether, or does that not help for your purpose? |
Author
|
Yeah I noticed that flag, but it doesn't help as I still want to limit the time to detect infinite loops. However, this flag does beg the question of whether to add a flag to change the initial 30 seconds. |
Contributor
|
Fair enough. The init flag is probably not as useful. |
snaar
requested changes
Nov 26, 2018
| constants.DEFAULT_MAP_HEIGHT, | ||
| "positive integer", cmd); | ||
| ValueArg<unsigned int> seed_arg("s", "seed", "The seed for the map generator.", false, 0, "positive integer", cmd); | ||
| ValueArg<unsigned int> timeout_arg("", "timeout", "Bot timeouts in milliseconds.", false, 2000, "positive integer", cmd); |
Contributor
There was a problem hiding this comment.
I'd like 2000 to be in a single place as magic constant. Right now it's also in
How about creating constexpr in NetworkingConfig.hpp with 2000 and refer to that here and in the NetworkingConfig struct instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot timeouts are currently fixed at 2000 milliseconds. This flag allows one to change this constant for debugging purposes.