chore: add nix flake#19
Conversation
nickgirardo
left a comment
nickgirardo
left a comment
There was a problem hiding this comment.
@Handfish asked me to take a look at this since I'm familiar with Nix. I just had a few minor concerns, overall looks good!
| protobuf | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
What's the reason for skipping the tests here?
There was a problem hiding this comment.
Ah, sorry, my bad :( - I skipped them to sped up development and forgot to remove it.
| description = "Talos TUI for real-time node monitoring, log streaming, etcd health, and diagnostics"; | ||
| homepage = "https://github.com/Handfish/talos-pilot"; | ||
| license = with lib.licenses; [ mit ]; | ||
| platforms = lib.platforms.linux; |
There was a problem hiding this comment.
Linux is hardcoded as the platform here, but this is built for all default systems (meaning this will also be built for darwin). This field isn't mandatory so it can just be removed for simplicity
| packages = with pkgs; [ | ||
| nixd | ||
| nixfmt-rfc-style | ||
| ]; |
There was a problem hiding this comment.
These don't really seem super relevant to the project as a whole, but I don't necessarily mind keeping these in for editing this file.
There was a problem hiding this comment.
Agree, removed it as well.
ajgon
force-pushed
the
chore/nix-flake
branch
from
3f1c697 to
1a40340
Compare
3 participants
Adds nix flake, and relevant documentation how to install/use talos-pilot on Nix.