Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damit wir den
RandomReviewersButtoneinheitlich auf der PR-Page, als auch auf der "Comparing changes"-Page haben, habe ich ihn verschoben zu Reviewers:Sieht zwar besser aus, aber wenn Reviewers re-rendert (Reviewer wurde hinzugefügt/entfernt), ist der Button weg und man muss die Page neu laden.
Technisches Problem: wir haben keinen fertigen PR, sondern nur Refs.
Angenommen, wir haben folgende Compare-Page mit URL:
<owner>/<repo>/compare/main...dummy/for-screenshots3Dann macht GitHub folgenden GET request:
<owner>/<repo>/pull/new/review-requests/main...dummy%2Ffor-screenshots3Das ist soweit, wie auf der PR-Page.
Der POST-Request scheint aber Form-Data rauszuschicken:
Und die Server-Response ist ein HTML:
Whooooooot 🤯
@lukegskw vielleicht hast du eine Idee 💡