Merged
Conversation
Co-authored-by: HappyOnigiri <nodemeld+happy-onigiri@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughRefixの自動マージ後のPRに対して Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Resolved conflict by keeping English comment from origin/main and adding refix:merged label info in English (consistent with rest of README).
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/auto_fixer.py`:
- Around line 1736-1737: The call to _backfill_merged_labels runs outside the
modified_prs counting and thus can change multiple PRs regardless of
max_modified_prs_per_run; update the logic so merged-label backfilling is
subject to the same limit by either (a) moving the _backfill_merged_labels work
into the same processing loop that consumes modified_prs and only run it while
remaining_modifications > 0, or (b) change _backfill_merged_labels to return the
number of PRs it modified and subtract that from remaining_modifications
(max_modified_prs_per_run), and check remaining_modifications before performing
each label update; apply the same fix at the other occurrence referenced (lines
around the second call).
- Around line 1201-1238: The function _mark_pr_merged_label_if_needed currently
bases eligibility only on mergedAt and REFIX_DONE_LABEL; change it to also
require that the PR was requested to be auto-merged before adding
REFIX_MERGED_LABEL — e.g. check for a dedicated auto-merge marker by calling
_pr_has_label(pr_data, REFIX_AUTO_MERGE_LABEL) or inspect the GH API field (add
the appropriate key to the gh --json list and check
pr_data.get("autoMergeRequest")/pr_data.get("autoMerge") is truthy); only if
mergedAt is set, REFIX_DONE_LABEL is present, and auto-merge is indicated should
you call _set_pr_merged_label(repo, pr_number) and add the label.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 75db8cf0-d927-4d4e-994c-fdef16326dda
📒 Files selected for processing (4)
.refix.yaml.sampleREADME.mdsrc/auto_fixer.pytests/test_auto_fixer.py
_mark_pr_merged_label_if_needed now fetches the autoMergeRequest field and returns early if auto-merge was not requested, preventing the label from being applied to manually-merged PRs. _backfill_merged_labels is updated to call _mark_pr_merged_label_if_needed instead of _set_pr_merged_label directly, so the same auto-merge guard applies during backfill.
The two _backfill_merged_labels calls were outside the modification count, allowing them to bypass max_modified_prs_per_run. - Pre-loop backfill uses max_modified_prs as its limit when set, and stores the returned count in backfilled_count. - The per-PR limit check now includes backfilled_count so backfilled PRs reduce the budget available for open-PR processing. - Post-loop backfill computes the remaining budget and skips the call entirely when the limit is already exhausted.
Owner
Author
🤖 Auto Review Fixer Status処理済みレビュー一覧 (System Use Only)
|
…rameter
- assert_called_once_with("owner/repo", limit=100) for backfill call when max_modified_prs==0
- add autoMergeRequest field to pr_view in test_mark_pr_merged_label_if_needed test
- patch _mark_pr_merged_label_if_needed instead of subprocess.run in backfill test to avoid cross-call mock collision
HappyOnigiri
added
refix:done
This was referenced Mar 11, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
refix:mergedlabel to PRs upon successful automatic merge by Refix to clearly indicate their completion status.Summary by CodeRabbit
リリースノート
新機能
ドキュメント
テスト