-
Notifications
You must be signed in to change notification settings - Fork 152
PAL Randomizer support #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PurpleHato
wants to merge
57
commits into
HarbourMasters:develop
Choose a base branch
from
PurpleHato:PalRando
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PAL Randomizer support #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage data until ztextmm is updated
…ile_choose_NES working
…and Use N64 gameplay_keep, link_anime, icon_item, copyright logo
- StaticData entries - Placeholder for Rando Items mapping - Localisation of prefix, message - Variable rename for English (name to nameEng and article to articleEng) to follow localisation logic - Ugly coloured control code on ItemGet messages - added CustomMessage::ReplaceSpecialChars helper function
- EnGirlA support - added a missing entry in french in the item.cpp - comment clearer for EnGs.cpp - german ß and _ replacement in the ReplaceSpecialChars function
Thanks to Schicksal for the German translations Co-Authored-By: Schicksal88 <20690605+schicksal88@users.noreply.github.com>
… working on my machine
* Draw a frog * wip * builds and doesn't crash * add to regions and fix flag stuff * notes * add menu option * progress * mostly works * format * fix postLimbCrash * fix logic * formatting * cleanup * move to DrawFuncs * rearrange includes to satisfy clang format * Make frogs give check when wearing Don Gero's Mask (HarbourMasters#5) * add second text variation * fix init issue --------- Co-authored-by: Caladius <clatini88@gmail.com> Co-authored-by: Eblo <7004497+Eblo@users.noreply.github.com>
* Add rando setting for minimum Stray Fairies * Fix bug with consecutive Great Fairy cutscenes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1231
This is a WIP PR aimed at making the 2Ship randomizer compatible with the PAL version of the game
Instead, report them to the dependent PR linked above
Thanks to @Schicksal88 for the german translations and guidance for their specific cases
✅Done:
gSaveContext.options.languagesupportYou got itemnamestrings, since the natural German phrasing isDu hast itemName erhaltenRandoStaticItem > Itemssupport🔧Todo:
Example screenshots:
Build Artifacts