Exclude Triforce from plentiful items, add error handling #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eblo
added a commit
that referenced
this pull request
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the player has Plentiful Items and Triforce Hunt both enabled, they can step on each other and result in seeds where the required and total Triforce piece counts are not valid. Since Triforce Hunt itself allows the player to control the total, it's redundant to include Triforce pieces in Plentiful Items. This simply excludes them.
Also added minor error handling after the Triforce piece ratio calculation, just in case there are other ways to generate invalid counts.
Build Artifacts