-
Notifications
You must be signed in to change notification settings - Fork 3
Add location groups #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: oot-soh
Are you sure you want to change the base?
Conversation
|
What do we gain exactly from location groups |
|
@jeromkiller mostly shortcuts for yaml settings. For example if you want to exclude the entirety of Fire Temple, you would put |
|
I think the location groups are great, but we really should think of adding tags to all locations and build these data sets from there. Over 1000 lines of duplicate locations is not great, and I can guarantee people are going to forgot to add new locations to these sets eventually. |
|
Maybe we can look into updating the add_locations function, so you can add a list of tags to each location and have it build the sets during the creation of the regions? Or we could also add extra data to the location definitions themselves like we do with the item location table. that way you can say what group a location belongs to as you define it |
#72 Has this. They key changes really only used the Dungeon part, but I included a list for tags for categorizing locations. |
|
When #72 gets merged, I'll pull this pr locally and see if I can write a script to turn all of the the groups into tags. |
Sorry for recreating this PR, I changed my repo setup to allow me to work on multiple AP projects.
What is this fixing or adding?
This PR adds location groups for Songs, Heart Containers, Gold Skulltula Rewards, Gold Skulltula Tokens, Archeries, Minigames, and all the dungeons.
Just so you don't have a new notification for nothing, I added a few locations compared to the previous PR, and renamed the groups to be more consistent with the location names that are used elsewhere in the project.
How was this tested?
It wasn't