Skip to content

Conversation

@wolicodes
Copy link

Sorry for recreating this PR, I changed my repo setup to allow me to work on multiple AP projects.

What is this fixing or adding?

This PR adds location groups for Songs, Heart Containers, Gold Skulltula Rewards, Gold Skulltula Tokens, Archeries, Minigames, and all the dungeons.
Just so you don't have a new notification for nothing, I added a few locations compared to the previous PR, and renamed the groups to be more consistent with the location names that are used elsewhere in the project.

How was this tested?

It wasn't

@jeromkiller
Copy link
Member

What do we gain exactly from location groups

@wolicodes
Copy link
Author

wolicodes commented Nov 21, 2025

@jeromkiller mostly shortcuts for yaml settings. For example if you want to exclude the entirety of Fire Temple, you would put "Fire Temple" in your exclude_locations settings instead of hunting down every check's name individually to add it there. You can also use the groups in priority_locations, or in plando blocks, etc.

@aMannus
Copy link

aMannus commented Dec 9, 2025

I think the location groups are great, but we really should think of adding tags to all locations and build these data sets from there. Over 1000 lines of duplicate locations is not great, and I can guarantee people are going to forgot to add new locations to these sets eventually.

@jeromkiller
Copy link
Member

jeromkiller commented Dec 25, 2025

Maybe we can look into updating the add_locations function, so you can add a list of tags to each location and have it build the sets during the creation of the regions?

Or we could also add extra data to the location definitions themselves like we do with the item location table. that way you can say what group a location belongs to as you define it

@mattman107
Copy link

mattman107 commented Dec 26, 2025

Or we could also add extra data to the location definitions themselves like we do with the item location table. that way you can say what group a location belongs to as you define it

#72 Has this. They key changes really only used the Dungeon part, but I included a list for tags for categorizing locations.

@jeromkiller
Copy link
Member

When #72 gets merged, I'll pull this pr locally and see if I can write a script to turn all of the the groups into tags.
I'll make sure to add Woli as a co-author so they get the credit they deserve for putting all of these together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants