-
Notifications
You must be signed in to change notification settings - Fork 631
Cheat: Child Link Can Hold Hylian Shield (Modern Codebase Port) #5990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nclok1405
wants to merge
9
commits into
HarbourMasters:develop
Choose a base branch
from
nclok1405:childholdshylianshield
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Cheat: Child Link Can Hold Hylian Shield (Modern Codebase Port) #5990
nclok1405
wants to merge
9
commits into
HarbourMasters:develop
from
nclok1405:childholdshylianshield
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sters#3887) to modern codebase
* Maybe "Show Age-Dependent Equipment" is not required?
TODO: mods.cpp is going to be retired and graphics patches will need to be moved into its own cpp file eventually
serprex
reviewed
Nov 27, 2025
serprex
reviewed
Jan 5, 2026
| #include "objects/object_link_boy/object_link_boy.h" | ||
| #include "objects/object_link_child/object_link_child.h" | ||
|
|
||
| extern SaveContext gSaveContext; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| extern SaveContext gSaveContext; |
serprex
reviewed
Jan 5, 2026
| return false; // Skip vanilla check for making child Link have the Hylian Shield on his back, allowing for it to | ||
| // be used in hand | ||
| } else { | ||
| return gSaveContext.linkAge != 0 && (this->currentShield == PLAYER_SHIELD_HYLIAN); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be return GameInteractor_Should(...) with *should = false in handler instead of doing cvar check here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental port of Patrick12115's "Child Link Can Hold Hylian Shield" (#3887) to the modern codebase.
I also moved the category of this option from Enhancements to Cheat, and modified Octorok's projectile to be reflectable with this option.
Build Artifacts