Add Blood Color options to Cosmetics Editor #6007
Conversation
| } | ||
|
|
||
| // (Un)register Hooks | ||
| if (manualChange) { |
There was a problem hiding this comment.
this shouldn't be necessary with shipinit hooks
There was a problem hiding this comment.
Normally not necessary due to automatic register/unregister calls by shipinit, but in my case it doesn't work. Despite all relevant CVar names (CVAR_COSMETIC("Blood.Blue0Begin.Changed") etc) are listed to be watched by RegisterShipInitFunc, the RegisterBlue/GreenBloodHook functions never gets called automatically when blood colors are changed from the default.
| } | ||
|
|
||
| static void RegisterBlueBloodHook() { | ||
| static bool previousHookState = false; // Previous hook enabled state (we don't re-register if unchanged) |
There was a problem hiding this comment.
COND_VB_SHOULD handles this, can remove this variable. Same for green blood
There was a problem hiding this comment.
If the register functions are automatically called by shipinit then this isn't needed. As of now, the register functions aren't called automatically by shipinit for some reason.
|
Would this replace the old red ganon blood option in restorations? |
No. Codes related to Ganon blood exist in completely separate locations from regular enemy blood splatter/hitmark. |
3 participants
This Pull Request adds enemy blood color options to Cosmetics Editor.
(Please note Mac build is repeatedly and randomly failing. I don't own a Mac, so if I introduce Mac-exclusive bugs, I can't fix it myself.)
Build Artifacts