Fix 2hand idle animation #6093
Fix 2hand idle animation #6093
Conversation
|
Should be now proper and not just outright bad |
|
Thank you for fixing it Reppan, it was one of my first enhancements and probably still one of my favourite 💜 |
| (Player_GetMeleeWeaponHeld2(this) != 0)))) { | ||
| (Player_GetMeleeWeaponHeld2(this) != 0))) || | ||
| ((commonType + FIDGET_SWORD_SWING == FIDGET_SWORD_SWING) && | ||
| Player_HoldsTwoHandedWeapon(this))) { |
There was a problem hiding this comment.
Is this part necessary?
There was a problem hiding this comment.
Yes. i have tried to remove it but without it 2handed idle animation just will not play
There was a problem hiding this comment.
My hunch is this is likely due to my other comment about the VB part being wrong
| if ((commonType + FIDGET_SWORD_SWING == FIDGET_SWORD_SWING) && | ||
| Player_HoldsTwoHandedWeapon(this) && | ||
| CVarGetInteger(CVAR_ENHANCEMENT("TwoHandedIdle"), 0) == 1) { | ||
| //! @bug This code is unreachable. |
There was a problem hiding this comment.
Rather than remove the original decomp comment, we can add our own explaining the user can opt to fix this bug
| } | ||
|
|
||
| static void RegisterFidgetIdleOverrides() { | ||
| REGISTER_VB_SHOULD(VB_TWO_HANDED_FIDGET_IDLE, { |
There was a problem hiding this comment.
Use COND_VB_SHOULD here
| REGISTER_VB_SHOULD(VB_TWO_HANDED_FIDGET_IDLE, { | ||
| // Only allow the two-handed fidget when the toggle is enabled; otherwise keep vanilla behavior. | ||
| if (*should) { | ||
| *should = CVarGetInteger(CVAR_ENHANCEMENT("TwoHandedIdle"), 0) != 0; |
There was a problem hiding this comment.
Looking at the original implementation, this should be doing a comparison check with the common type arg
|
how did i even nuke this one???? |
4 participants
add a VB to enable 2hand idle animation
Build Artifacts