-
Notifications
You must be signed in to change notification settings - Fork 630
[Custom equipment] fix fallback #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[Custom equipment] fix fallback #6113
Conversation
Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
|
Ive gotten some reports of more stuff to fix with custom equipment. Do you want me to make a new pr or do you want to hold of the merge and i can send them in here? |
|
collecting them here is good, please ask people to test artifacts of this PR, that way all fixes are tested |
|
Its not necessarily a fix per say but i have a draft of for making it work with Shieldless child link to have master sword/bgs on back properly. Requires adding calls in z_player_lib.c . Is that fine? |
|
Please keep that separate |
|
I've fixed all currently known issues for now. should be ready for review and merge After todays fixing i noticed a small thing about anchor multiplayer which is not a blocker per say but to make patching fully compatible either anchor or resourcemanager needs some changes to allow patches to happen on separate players. I want some opinion on that eventually. Main issue in anchor for now is that all patches makes changes so all sword and shields technically matches the local players layout. so visually it can look like another player have BGS equipped but it will look like kokiri sword to the local player if patched by custom equipment is applied. @garrettjoecox pinging you since youre the anchor guy |
Fallback system for the 2 handed swords were failing between giants knife and broken giants knife.
Build Artifacts