Skip to content

Conversation

@Jepvid
Copy link
Contributor

@Jepvid Jepvid commented Jan 6, 2026

Fallback system for the 2 handed swords were failing between giants knife and broken giants knife.

Build Artifacts

Co-authored-by: Philip Dubé <serprex@users.noreply.github.com>
@Jepvid
Copy link
Contributor Author

Jepvid commented Jan 7, 2026

Ive gotten some reports of more stuff to fix with custom equipment. Do you want me to make a new pr or do you want to hold of the merge and i can send them in here?

@serprex
Copy link
Contributor

serprex commented Jan 8, 2026

collecting them here is good, please ask people to test artifacts of this PR, that way all fixes are tested

@Jepvid
Copy link
Contributor Author

Jepvid commented Jan 9, 2026

Its not necessarily a fix per say but i have a draft of for making it work with Shieldless child link to have master sword/bgs on back properly. Requires adding calls in z_player_lib.c . Is that fine?

@serprex
Copy link
Contributor

serprex commented Jan 9, 2026

Please keep that separate

@Jepvid
Copy link
Contributor Author

Jepvid commented Jan 10, 2026

I've fixed all currently known issues for now. should be ready for review and merge

After todays fixing i noticed a small thing about anchor multiplayer which is not a blocker per say but to make patching fully compatible either anchor or resourcemanager needs some changes to allow patches to happen on separate players. I want some opinion on that eventually.

Main issue in anchor for now is that all patches makes changes so all sword and shields technically matches the local players layout. so visually it can look like another player have BGS equipped but it will look like kokiri sword to the local player if patched by custom equipment is applied.

@garrettjoecox pinging you since youre the anchor guy

@serprex serprex requested a review from garrettjoecox January 10, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants