Merged
Conversation
use https://github.com/sonicdcer/N64ModernRuntime/blob/controllerpakimpl/librecomp/src/pak.cpp as a ref Co-Authored-By: Alejandro Asenjo Nitti <96613413+sonicdcer@users.noreply.github.com>
Co-authored-by: Dario <dariosamo@gmail.com> Co-authored-by: Mr-Wiseguy <mrwiseguyromhacking@gmail.com>
MegaMech
requested changes
Jul 28, 2025
| osPfsReadWriteFile(&gControllerPak2FileHandle, gControllerPak2FileNote, 0U, | ||
| (arg0 * (sizeof(u8) * 0x1000)) + 0x100, sizeof(u8) * 0x1000, (u8*) sReplayGhostBuffer); | ||
| osPfsReadWriteFile(&gControllerPak2FileHandle, gControllerPak2FileNote, PFS_READ, | ||
| (arg0 * (sizeof(u8) * 0x10000)) + 0x100, sizeof(u8) * 0x10000, (u8*) sReplayGhostBuffer); |
Contributor
Author
There was a problem hiding this comment.
yes to avoid some bug
| const u8 gGameName[] = "MARIOKART64"; | ||
| const u8 gGameName[] = { | ||
| 0x26, 0x1a, 0x2b, 0x22, 0x28, 0x24, 0x1a, 0x2b, 0x2d, 0x16, 0x14, 0x00, 0x00, 0x00, 0x00, 0x00 | ||
| }; |
Contributor
There was a problem hiding this comment.
This change is required for byte-matching output?
Contributor
Author
There was a problem hiding this comment.
for the screen because else it's weird symbole (font system etc)
| AddWidget(path, "Controller pak screen", WIDGET_CVAR_CHECKBOX) | ||
| .CVar("gControllerPakScreen") | ||
| .Options(CheckboxOptions().Tooltip( | ||
| "Enables the Controller Pak screen when starting the game.")); |
Contributor
There was a problem hiding this comment.
How about a physical button that puts the player to the pak screen, using gMenuSelection?
Contributor
Author
There was a problem hiding this comment.
hmm don't really want because not sure if it will be fine to trigger it at any time
Contributor
There was a problem hiding this comment.
It should be fine to trigger it any time.
src/port/pak.cpp
Outdated
| assert(false); | ||
| } | ||
| if (!pak.header.is_open()) { | ||
| assert(false); |
Contributor
There was a problem hiding this comment.
Replace asserts with errors or return errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared with permission by all contributors involved