fix build and run on OpenBSD #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ordingly to avoid read overflow. To revisit after further investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check commit logs.
The missing include is obvious but the read overflow check is just a workaround for now.
There should be a reason it doesn't crash on Linux, something is different on OpenBSD build.
Also the sound is bad, I don't know if it's related to the alignment issue.
I would like more tests as I'm running at 20 fps, maybe the sound quality is related to my setup.
Do I need to open an issue for the read overflow crash ?
Maybe that's more convenient if the proper fix isn't obvious ?
Note Shipwright also has the same issue, same place.