feat: add whitelist mode for subject attestation control#241
Merged
Haroldwonder merged 2 commits intoHaroldwonder:mainfrom Mar 27, 2026
Merged
feat: add whitelist mode for subject attestation control#241Haroldwonder merged 2 commits intoHaroldwonder:mainfrom
Haroldwonder merged 2 commits intoHaroldwonder:mainfrom
Conversation
|
@Mirabliss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some issuers need to restrict which subjects they can attest to (e.g., only pre-registered users).
Tasks
Add SubjectWhitelist(Address) storage key per issuer
Add add_to_whitelist(env, issuer, subject) function
Add remove_from_whitelist(env, issuer, subject) function
Add whitelist_enabled: bool per issuer config
Check whitelist in create_attestation if enabled
Add unit tests
Acceptance Criteria
Whitelist disabled by default
When enabled, non-whitelisted subjects are rejected
Issuer controls their own whitelist
Whitelist check happens before storage writes
closes #33