Skip to content

Conversation

@Havret
Copy link
Owner

@Havret Havret commented Dec 30, 2025

No description provided.

@Havret Havret marked this pull request as ready for review December 30, 2025 21:50
@Havret Havret requested a review from Copilot December 30, 2025 21:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for ISet<T> collections to the RocksDb.Extensions library, mirroring the existing IList<T> functionality. The implementation refactors the existing list serializers by introducing base classes that can be shared between list and set serializers.

Key Changes:

  • Introduced abstract base classes FixedSizeCollectionSerializer and VariableSizeCollectionSerializer for code reuse
  • Created FixedSizeSetSerializer and VariableSizeSetSerializer for set-specific implementations
  • Refactored existing list serializers to inherit from the new base classes
  • Updated RocksDbBuilder to automatically create appropriate serializers for ISet<T> types
  • Added comprehensive test coverage for set support across all serializer types

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/RocksDb.Extensions/FixedSizeCollectionSerializer.cs New abstract base class for serializing collections with fixed-size elements (primitives)
src/RocksDb.Extensions/VariableSizeCollectionSerializer.cs New abstract base class for serializing collections with variable-size elements (strings, complex objects)
src/RocksDb.Extensions/FixedSizeSetSerializer.cs Concrete implementation for serializing ISet with fixed-size elements
src/RocksDb.Extensions/VariableSizeSetSerializer.cs Concrete implementation for serializing ISet with variable-size elements
src/RocksDb.Extensions/FixedSizeListSerializer.cs Refactored to extend FixedSizeCollectionSerializer base class
src/RocksDb.Extensions/VariableSizeListSerializer.cs Refactored to extend VariableSizeCollectionSerializer base class
src/RocksDb.Extensions/RocksDbBuilder.cs Added logic to detect ISet types and create appropriate serializers (fixed vs variable size)
test/RocksDb.Extensions.Tests/RocksDbStoreWithProtobufSerializerTests.cs Added test for set support with Protobuf serializer
test/RocksDb.Extensions.Tests/RocksDbStoreWithProtoBufNetSerializerTests.cs Added test for set support with ProtoBufNet serializer
test/RocksDb.Extensions.Tests/RocksDbStoreWithPrimitiveSerializerTests.cs Added tests for set support with primitive types (int and string)
test/RocksDb.Extensions.Tests/RocksDbStoreWithJsonSerializerTests.cs Added test for set support with JSON serializer
README.md Updated documentation to reflect ISet support alongside IList

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Havret Havret merged commit 153a33d into main Jan 2, 2026
7 checks passed
@Havret Havret deleted the Add-Set-Support branch January 2, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants