Fix windows bash; Add linux shell #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add linux shell script
saper
reviewed
Feb 24, 2018
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Can you change it to #!/bin/sh
Some systems do not have bash installed, and the only bash-specific thing is -n1 key parameter to read
saper
reviewed
Feb 24, 2018
| #7z a -tzip release.zip release | ||
| #rm -rf release | ||
| #haxelib submit release.zip | ||
| read -rsp $'Press any key to continue...\n' -n1 key No newline at end of file |
There was a problem hiding this comment.
Is this really needed? We can remove this line I think
saper
reviewed
Feb 24, 2018
saper
left a comment
saper
left a comment
There was a problem hiding this comment.
Let's avoid bash-specific code if we can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.