show the grouping filter when grouping_columns is defined#86
Open
oxymor0n wants to merge 2 commits intoHazyResearch:masterfrom
Open
show the grouping filter when grouping_columns is defined#86oxymor0n wants to merge 2 commits intoHazyResearch:masterfrom
grouping_columns is defined#86oxymor0n wants to merge 2 commits intoHazyResearch:masterfrom
Conversation
…defined previously, if the `grouping_columns` config is defined, but no `groupFilter` is set (i.e. the `g` parameter on the URL is empty), then the mindtagger UI would not show the grouping filter element, which then prevents the `groupFilter` from being set. this patch shows the grouping filter by default if `MindtaggerTask.config.items.grouping_columns` is defined, allowing the users to freely set their group filter from the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, if the
grouping_columnsconfig is defined, but nogroupFilteris set(i.e. the
gparameter on the URL is empty), then the mindtagger UI would not showthe grouping filter element, which then prevents the
groupFilterfrom being set.this patch shows the grouping filter by default if
MindtaggerTask.config.items.grouping_columnsis defined, allowing the users to freely set their group filter from the UI.