Extracted tests and updated Pytorch version#9
Open
thomasahle wants to merge 1 commit intoHazyResearch:masterfrom
Open
Extracted tests and updated Pytorch version#9thomasahle wants to merge 1 commit intoHazyResearch:masterfrom
thomasahle wants to merge 1 commit intoHazyResearch:masterfrom
Conversation
albertfgu
reviewed
Nov 10, 2022
Contributor
albertfgu
left a comment
albertfgu
left a comment
There was a problem hiding this comment.
Thanks for making such a comprehensive refactor!
I have a few questions about some of the changes
- Are the CUDA kernels no longer used? E.g. why are
diag_mult_cuda/setup.pyandhadamard_cuda/setup.pydeleted? - Is the code inside the
scratch/folder moved to tests, or deleted? I would prefer preserving the original code since it's clearly labeled as not part of the critical codepath but helps remind us of the progress that went into this project
It would have been ideal if the formatter changes were done in an independent commit to the actual changes, but I understand it's probably hard to factor that out so don't worry about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #7 in which we discussed updating the code to use PyTorch's complex tensors.
The pull request also extracts all tests into a
tests/directory, so it's easy to run unit tests. All 12 of which pass.Other than there there are no changes, except auto formatting which my tools unfortunately don't allow me not to use.