Conversation
henryre
left a comment
henryre
left a comment
There was a problem hiding this comment.
Definitely needs to be tested as well. For next rev, can use the MNIST small example script
keras/utils.py
Outdated
There was a problem hiding this comment.
This seems like way too strong of an assumption. Any other ideas on how to load in TFs?
There was a problem hiding this comment.
Fixed in latest commit- we just pickle them using the cloud lib (a good logging / reproducibility step regardless), then just load them in; much simpler. And all handled in the train_scripts.py file
keras/utils.py
Outdated
There was a problem hiding this comment.
Is this where this file is always located? I think it's usually in logs, just like this for the pretrained dir
keras/tanda_keras.py
Outdated
There was a problem hiding this comment.
Definitely need to allow user to pass in TAN object. Can use isinstance(tan, str)
experiments/cifar10/train.py
Outdated
There was a problem hiding this comment.
Breaks if any experiment subdir contains "tanda" right?
There was a problem hiding this comment.
Also shouldnt this be somewhere in train_scripts.py?
|
@henryre ready for re-review! Can be tested when training new TANs |
|
Ok will look soon! |
henryre
left a comment
henryre
left a comment
There was a problem hiding this comment.
Let's run a basic test here to make sure these changes work
experiments/cifar10/train.py
Outdated
experiments/cifar10/train.py
Outdated
| import tensorflow as tf | ||
| import tensorflow.contrib.slim as slim | ||
| import sys | ||
| import cloud |
There was a problem hiding this comment.
Needs to be added to package requirement
There was a problem hiding this comment.
Also why this instead of e.g. dill?
keras/utils.py
Outdated
pretrained/cifar10/logs/run_log.json
Outdated
experiments/train_scripts.py
Outdated
|
@henryre Addressed all inline comments |
experiments/cifar10/train.py
Outdated
keras/utils.py
Outdated
python-package-requirement.txt
Outdated
|
@henryre changes made |
2 participants
Still needs to be tested