Open
Conversation
… before_action callback
…nd paragraph, and add TODO for missing demo page.
…d updating components to use it
…ot_path for better routing
…nd ds_grid; fix broken Cypress test for footer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refurbish dummy app preview pages with a two_column layout
Why?
This resembles all the other design system guideline pages and reduces user's cognitive load to get their hands on.
How?
two_columnlayout to dummy appcomponent_previewwhich will capture a block of erb code and render its html outputstyles_controllerandcomponents_controllerto manage sub-pagespages#indexinto individual viewsds_codeand self-hostinghljsTesting?
All passed and eyeballed
Specific content in each page will be discussed with @rebecafiadeiro later and will subject to changes
Screenshots (optional)
Anything Else?
This is just a scaffolding for page refurbishments. I've left quite some TODO notes to work on. Happy to discuss